Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

normalize use of backticks for compiler messages in librustc_codegen #62478

Merged
merged 1 commit into from
Jul 8, 2019
Merged

normalize use of backticks for compiler messages in librustc_codegen #62478

merged 1 commit into from
Jul 8, 2019
+11 −11

Conversation

fakenine
Copy link
Contributor

@fakenine fakenine commented Jul 7, 2019

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 7, 2019
@fakenine
Copy link
Contributor Author

fakenine commented Jul 7, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned pnkfelix Jul 7, 2019
@Centril
Copy link
Contributor

Centril commented Jul 7, 2019

Thanks! @bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 7, 2019

📌 Commit 8aa9f18 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Jul 8, 2019
@Centril
Rollup merge of rust-lang#62478 - fakenine:normalize_use_of_backticks…
1f23835 
…_compiler_messages_p3, r=Centril

normalize use of backticks for compiler messages in librustc_codegen

rust-lang#60532
@Centril Centril mentioned this pull request Jul 8, 2019
Closed
Centril added a commit to Centril/rust that referenced this pull request Jul 8, 2019
@Centril
Rollup merge of rust-lang#62478 - fakenine:normalize_use_of_backticks…
ada2684 
…_compiler_messages_p3, r=Centril

normalize use of backticks for compiler messages in librustc_codegen

rust-lang#60532
@Centril Centril mentioned this pull request Jul 8, 2019
Merged
bors added a commit that referenced this pull request Jul 8, 2019
@bors
Auto merge of #62485 - Centril:rollup-gg3it1u, r=Centril
db592f4 
Rollup of 5 pull requests

Successful merges:

 - #62356 (Implement Option::contains and Result::contains)
 - #62462 (Document `while` keyword)
 - #62472 (Normalize use of backticks in compiler messages p2)
 - #62477 (Re-add bootstrap attribute to libunwind for llvm-libunwind feature)
 - #62478 (normalize use of backticks for compiler messages in librustc_codegen)

Failed merges:

r? @ghost
@bors bors merged commit 8aa9f18 into rust-lang:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Centril Centril

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fakenine @rust-highfive @Centril @bors @pnkfelix